feat: implement {mapValues,mapKeys}Async functions #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rossyman
force-pushed
the
feat/async-object-mapping
branch
from
21e5def to
efe997a
Compare
rossyman
force-pushed
the
feat/async-object-mapping
branch
from
efe997a to
299d576
Compare
kss2002
reviewed
Dec 1, 2025
There was a problem hiding this comment.
안녕하세요.
비동기 함수 관련 md를 잘 추가하셨네요.
다름이 아니라 "~니다" 체보다는 "~요"체를 사용하는 것은 어떠실까요?
다른 문서에서는 "~요"체를 사용하고 있어요!
-> 관련 경로
docs/ko/reference/object/mapKeysAsync.md
docs/ko/reference/object/mapValuesAsync.md
감사합니다.
Author
There was a problem hiding this comment.
감사합니다.
말씀하신 "~요" 체 관련 피드백 반영해서 PR 업데이트했습니다.
추가로 수정 필요한 부분 있으시면 말씀 부탁드립니다.
Thanks for reviewing my changes! I've updated the PR to reflect your feedback on using "~yo" forms in the documentation. If you notice anything else that needs to be changed, let me know.
rossyman
force-pushed
the
feat/async-object-mapping
branch
from
299d576 to
b3938b7
Compare
rossyman
force-pushed
the
feat/async-object-mapping
branch
from
b3938b7 to
cb74770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements async variants of
mapValuesandmapKeys.Changes
limitAsyncprior-artSemaphore, it may make more sense for this to live within/promiserather than/arraymapValuesAsyncobject sub-functionmapValueslimitAsyncmapKeysAsyncobject sub-functionmapKeyslimitAsyncmapValuesAsyncandmapKeysAsyncmapValuesAsyncandmapKeysAsyncBenchmarking
mapAsync,filterAsync, etc)asyncgoing forward